Use Scope class for filtering/where impl. for Model #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
mvorisek
reviewed
Jul 21, 2020
DarkSide666
requested changes
Jul 23, 2020
georgehristov
commented
Jul 23, 2020
| @@ -178,14 +178,14 @@ public function toWords(Model $model = null): string | |||
| */ | |||
| public static function createAnd(...$conditions) | |||
| { | |||
| return new self($conditions, self::AND); | |||
| return new static($conditions, self::AND); | |||
There was a problem hiding this comment.
self is intentional as using Model\Scope::createAnd brings unexpected results
DarkSide666
approved these changes
Jul 23, 2020
georgehristov
force-pushed
the
feature/model-scope-basic
branch
from
8b119a6
to
8123cff
Compare
georgehristov
force-pushed
the
feature/model-scope-basic
branch
from
8123cff
to
954db74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic features of #551
Related to #524